OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420879420
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2626,8 +2601,16 @@ class ReplicaManager(val config: KafkaConfig,
localLeaders.forKeyValue { (tp, info) =>
getOrCreatePartition(tp, delta, info.topicId).foreach { case (partition,
isNew) =>
try {
+ val partitionDirectoryId: Option[Uuid] =
+ Option(newImage.topics().getPartition(info.topicId(),
partition.partitionId)).map(_.directory(localBrokerId))
Review Comment:
I don't see the value of defaulting to `MIGRATING` instead of Option. I
would leave as Option for now and if we want to change this later because it
cause an issue we can do that latter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
