kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421201698
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -113,16 +113,15 @@ public void process(ApplicationEvent event) {
process((UnsubscribeApplicationEvent) event);
return;
+ case CONSUMER_REBALANCE_LISTENER_CALLBACK_COMPLETED:
Review Comment:
The logic in `ApplicationEventProcessor` is _supposed_ to be glue code
between the event from the application thread and resources in the background
thread. As such, the core logic for that interaction with the background thread
resource is _supposed_ to live in the test for the resource.
That said, it couldn't hurt to have some tests here. It would likely surface
any regressions faster than trying to piece together which end of the glued
bits isn't acting correctly.
Is this something for which I can file a Jira and we can tackle in a
separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
