[ 
https://issues.apache.org/jira/browse/KAFKA-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523297#comment-16523297
 ] 

Dong Lin commented on KAFKA-6949:
---------------------------------

[~rsivaram] The patch has been merged into trunk. I opened PR 
[https://github.com/apache/kafka/pull/5293] to merge it into 2.0. Typically do 
we need review from another committer in order to cherry-pick patch from trunk 
into a release branch?

Also, I added fix version 2.0.0 in this JIRA. Please feel free to change it as 
you see appropriate. Thanks.

 

> alterReplicaLogDirs() should grab partition lock when accessing log of the 
> future replica
> -----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-6949
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6949
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Dong Lin
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> I found this in a failed execution of 
> kafka.admin.ReassignPartitionsClusterTest.shouldExpandCluster. Looks like 
> we're missing some option checking.
> {code}
> [2018-05-25 08:03:53,310] ERROR [ReplicaManager broker=100] Error while 
> changing replica dir for partition my-topic-2 (kafka.server.ReplicaManager:76)
> java.util.NoSuchElementException: None.get
>       at scala.None$.get(Option.scala:347)
>       at scala.None$.get(Option.scala:345)
>       at 
> kafka.server.ReplicaManager$$anonfun$alterReplicaLogDirs$1.apply(ReplicaManager.scala:584)
>       at 
> kafka.server.ReplicaManager$$anonfun$alterReplicaLogDirs$1.apply(ReplicaManager.scala:576)
>       at 
> scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
>       at 
> scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
>       at scala.collection.Iterator$class.foreach(Iterator.scala:891)
>       at scala.collection.AbstractIterator.foreach(Iterator.scala:1334)
>       at scala.collection.IterableLike$class.foreach(IterableLike.scala:72)
>       at scala.collection.AbstractIterable.foreach(Iterable.scala:54)
>       at scala.collection.TraversableLike$class.map(TraversableLike.scala:234)
>       at scala.collection.AbstractTraversable.map(Traversable.scala:104)
>       at 
> kafka.server.ReplicaManager.alterReplicaLogDirs(ReplicaManager.scala:576)
>       at 
> kafka.server.KafkaApis.handleAlterReplicaLogDirsRequest(KafkaApis.scala:2037)
>       at kafka.server.KafkaApis.handle(KafkaApis.scala:138)
>       at kafka.server.KafkaRequestHandler.run(KafkaRequestHandler.scala:69)
>       at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to