lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422677966
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -790,6 +812,197 @@ public void
testOnSubscriptionUpdatedTransitionsToJoiningOnlyIfNotInGroup() {
verify(membershipManager, never()).transitionToJoining();
}
+ @Test
+ public void testListenerCallbacksBasic() {
Review Comment:
Agree @dajac , reconciliation should fail if the `onPartitionsRevoked`
fails, we're indeed missing that path here (it's only happening when
`onPartitionsAssigned` fails).
When `onPartitionsRevoked` fails, we intentionally invoke the
`onPartitionsAssigned` anyways as I was mentioning above (experience the legacy
consumer provides), but we should end up failing the reconciliation as it
happens when `onPartitionsAssign` fails. Makes sense @kirktrue ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
