dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424345912
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -719,20 +721,26 @@ public void run() {
result.records()
);
- timer.add(new TimerTask(timeout) {
+ timer.add(new TimerTask(timeout.toMillis()) {
@Override
public void run() {
- scheduleInternalOperation(name, tp, () ->
complete(new TimeoutException("Writing records to the log timed out")));
+ if (!future.isDone()) {
+ scheduleInternalOperation(
+ "LogAppendEvent(name=" + name + ",
tp=" + tp + ")",
+ tp,
+ () -> complete(new
TimeoutException("Log append event " + name + "timed out for TopicPartition " +
tp))
+ );
+ }
}
});
-
context.coordinator.updateLastWrittenOffset(offset);
-
// Add the response to the deferred queue.
if (!future.isDone()) {
context.deferredEventQueue.add(offset, this);
+
context.coordinator.updateLastWrittenOffset(offset);
Review Comment:
Why did you move this? I think that it should stay where it was and the
timer must be added here, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
