kamalcph commented on code in PR #14832: URL: https://github.com/apache/kafka/pull/14832#discussion_r1424357202
########## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ########## @@ -341,9 +341,10 @@ public void onLeadershipChange(Set<Partition> partitionsBecomeLeader, leaderPartitions.forEach(this::cacheTopicPartitionIds); followerPartitions.forEach(this::cacheTopicPartitionIds); + followerPartitions.forEach( + topicIdPartition -> brokerTopicStats.topicStats(topicIdPartition.topic()).removeRemoteCopyBytesLag(topicIdPartition.partition())); - remoteLogMetadataManager.onPartitionLeadershipChanges(leaderPartitions, followerPartitions); - followerPartitions.forEach(topicIdPartition -> + remoteLogMetadataManager.onPartitionLeadershipChanges(leaderPartitions, followerPartitions);followerPartitions.forEach(topicIdPartition -> Review Comment: please revert this change. Two statements in the same line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org