philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1424433876
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1050,6 +1062,81 @@ private void close(Duration timeout, boolean
swallowException) {
}
}
+ /**
+ * Prior to closing the network thread, we need to make sure the following
operations happen in the right sequence:
+ * 1. autocommit offsets
+ * 2. revoke all partitions
+ */
+ private void prepareShutdown(final Timer timer, final
AtomicReference<Throwable> firstException) {
+ if (!groupMetadata.isPresent())
+ return;
+ maybeAutoCommitSync(timer, firstException);
+ timer.update();
+ waitOnEventCompletion(new
ConsumerCloseApplicationEvent(ConsumerCloseApplicationEvent.Task.COMMIT,
timer.remainingMs()), timer, firstException);
+ maybeInvokeCommitCallbacks();
+ maybeRevokePartitions(timer, firstException);
+ waitOnEventCompletion(new
ConsumerCloseApplicationEvent(ConsumerCloseApplicationEvent.Task.LEAVE_GROUP,
timer.remainingMs()), timer, firstException);
+ }
+
+ private void waitOnEventCompletion(final ConsumerCloseApplicationEvent
event,
+ final Timer timer,
+ final AtomicReference<Throwable>
firstException) {
+ try {
+ applicationEventHandler.addAndGet(event, timer);
+ } catch (TimeoutException e) {
Review Comment:
@kirktrue and I discussed the potential tasks for dealing with zero timeout.
This needs to be examined perhaps after the preview. So we will spin off a
jira ticket for this specific issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
