dajac commented on code in PR #14848:
URL: https://github.com/apache/kafka/pull/14848#discussion_r1425601951
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java:
##########
@@ -71,21 +55,30 @@ public TimelineGaugeCounter(TimelineLong timelineLong,
AtomicLong atomicLong) {
this.atomicLong = atomicLong;
}
}
+ /**
+ * Consumer group size gauge counters keyed by the metric name.
+ */
+ private final Map<GenericGroupState, AtomicLong> genericGroupGauges;
/**
- * Local timeline gauge counters keyed by the metric name.
+ * Consumer group size gauge counters keyed by the metric name.
*/
- private final Map<String, TimelineGaugeCounter> localGauges;
+ private final Map<ConsumerGroup.ConsumerGroupState, TimelineGaugeCounter>
consumerGroupGauges;
Review Comment:
nit: Could we import `ConsumerGroupState`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
