pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426003081


##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -194,8 +194,13 @@ public enum MetadataVersion {
     // Add JBOD support for KRaft.
     IBP_3_7_IV2(17, "3.7", "IV2", true),
 
+    // IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved 
forward

Review Comment:
   Done!



##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -165,13 +165,15 @@ public void testFromVersionString() {
         assertEquals(IBP_3_6_IV1, 
MetadataVersion.fromVersionString("3.6-IV1"));
         assertEquals(IBP_3_6_IV2, 
MetadataVersion.fromVersionString("3.6-IV2"));
 
-        // 3.7-IV0 is the latest production version in the 3.7 line
-        assertEquals(IBP_3_7_IV0, MetadataVersion.fromVersionString("3.7"));
+        // 3.7-IV2 is the latest production version in the 3.7 line
+        assertEquals(IBP_3_7_IV2, MetadataVersion.fromVersionString("3.7"));

Review Comment:
   Fixed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to