dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1426839420
##########
core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala:
##########
@@ -135,7 +136,22 @@ class CoordinatorLoaderImpl[T](
memoryRecords.batches.forEach { batch =>
if (batch.isControlBatch) {
- throw new IllegalStateException("Control batches are not
supported yet.")
+ batch.asScala.foreach { record =>
Review Comment:
@jolshan If we have a control record for committing or aborting the
transaction, my understanding is that we must apply it. This means that all the
pending transactional offsets seen so far must be committed. Do you have a
suggestion for a better name? How about `replayEndTransactionMarker`?
@jeffkbkim What is it confusing? From a state machine perspective, the
transaction is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
