ableegoldman commented on code in PR #14949:
URL: https://github.com/apache/kafka/pull/14949#discussion_r1428577334
##########
docs/streams/upgrade-guide.html:
##########
@@ -185,6 +185,13 @@ <h3><a id="streams_api_changes_370"
href="#streams_api_changes_370">Streams API
</pre>
</p>
+ <p>
+ <code>default.dsl.store</code> was replaced with
<code>dsl.store.suppliers.class</code> to allow for custom store configuration.
Review Comment:
```suggestion
The <code>default.dsl.store</code> config was deprecated in favor of
the new
<code>dsl.store.suppliers.class</code> config to allow for custom
state store
implementations to be configured as the default.
```
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -310,6 +310,19 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
<td colspan="2">Default serializer/deserializer for the inner
class of windowed values, implementing the <code class="docutils literal"><span
class="pre">Serde</span></code> interface.</td>
<td>null</td>
</tr>
+ <tr class="row-even"><td>default.dsl.store</td>
+ <td>Low</td>
+ <td colspan="2">(Deprecated) The default state store type used by
DSL operators.</td>
+ <td><code>ROCKS_DB</code></td>
+ </tr>
+ <tr class="row-odd"><td>dsl.store.suppliers.class</td>
+ <td>Low</td>
+ <td colspan="2">
+ Defines which store implementations to plug in to DSL operators.
Must implement
Review Comment:
```suggestion
Defines a default state store implementation to be used by any
stateful DSL operator
that has not explicitly configured the store implementation
type. Must implement
```
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -310,6 +310,19 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
<td colspan="2">Default serializer/deserializer for the inner
class of windowed values, implementing the <code class="docutils literal"><span
class="pre">Serde</span></code> interface.</td>
<td>null</td>
</tr>
+ <tr class="row-even"><td>default.dsl.store</td>
+ <td>Low</td>
+ <td colspan="2">(Deprecated) The default state store type used by
DSL operators.</td>
Review Comment:
```suggestion
<td colspan="2">
[DEPRECATED] The default state store type used by DSL
operators. Deprecated in
favor of <code>dsl.store.suppliers.class</code>
</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
