kamalcph commented on code in PR #14375:
URL: https://github.com/apache/kafka/pull/14375#discussion_r1428646042
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -926,16 +926,27 @@ private boolean
deleteLogSegmentsDueToLeaderEpochCacheTruncation(EpochEntry earl
return isSegmentDeleted;
}
- private boolean deleteRemoteLogSegment(RemoteLogSegmentMetadata
segmentMetadata, Predicate<RemoteLogSegmentMetadata> predicate)
+ private boolean deleteRemoteLogSegment(String topic,
RemoteLogSegmentMetadata segmentMetadata, Predicate<RemoteLogSegmentMetadata>
predicate)
Review Comment:
Can we take the `topic` name from the segmentMetadata instead of propagating
it from the caller?
```
String topic = segmentMetadata.topicIdPartition().topic();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
