showuon commented on PR #15005: URL: https://github.com/apache/kafka/pull/15005#issuecomment-1858738944
> The following metrics are related to each other: > > 1. RemoteCopyLagBytes and RemoteCopyLagSegments > > 2. RemoteDeleteLagBytes and RemoteDeleteLagSegments > > > We should update their values in-sync by taking a lock. Now, both the values are being updated individually. There will be a deviation when the metric-reporter-thread reports them in the background. > > (eg) RemoteCopyLagBytes can be shown as 0 but RemoteCopyLagSegments can be shown as 1 in the Grafana dashboard. Shall we fix the discrepancy? This is a good point, but I think adding a lock is overkilling compared with the value discrepancy. I think the value deviation should be acceptable compared with sacrificing the performance using lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
