[ 
https://issues.apache.org/jira/browse/KAFKA-16027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Nee updated KAFKA-16027:
-------------------------------
    Description: 
MetadataTest#testUpdatePartitionLeadership is extremely long.  I think it is 
pretty close to the 160 line method limit - I tried to modfity it but it would 
hit the limit when i tried to break things into separated lines.

The test also contains two tests, so it is best to split it into two separate 
tests.

We should also move this to ConsumerMetadata.java

  was:
MetadataTest#testUpdatePartitionLeadership is extremely long.  I think it is 
pretty close to the 160 line method limit - I tried to modfity it but it would 
hit the limit when i tried to break things into separated lines.

The test also contains two tests, so it is best to split it into two separate 
tests.


> Refactor MetadataTest#testUpdatePartitionLeadership
> ---------------------------------------------------
>
>                 Key: KAFKA-16027
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16027
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Philip Nee
>            Priority: Minor
>              Labels: newbie
>
> MetadataTest#testUpdatePartitionLeadership is extremely long.  I think it is 
> pretty close to the 160 line method limit - I tried to modfity it but it 
> would hit the limit when i tried to break things into separated lines.
> The test also contains two tests, so it is best to split it into two separate 
> tests.
> We should also move this to ConsumerMetadata.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to