jolshan commented on code in PR #15023:
URL: https://github.com/apache/kafka/pull/15023#discussion_r1430476389
##########
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##########
@@ -1071,18 +1071,25 @@ protected boolean retainTopic(String topic, boolean
isInternal, long nowMs) {
public void testUpdatePartitionLeadership() {
Time time = new MockTime();
Review Comment:
Maybe we should split up the test for each of the features (2 partitions,
invalid topic, unauthorized topic, 1 internal topic). All the common logic can
be in a helper?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
