lianetm commented on code in PR #15033:
URL: https://github.com/apache/kafka/pull/15033#discussion_r1430516788
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -405,8 +405,8 @@ private void
processAssignmentReceived(ConsumerGroupHeartbeatResponseData.Assign
assignmentUnresolved, currentAssignment);
// Make sure we transition the member back to STABLE if it was
RECONCILING (ex.
// member was RECONCILING unresolved assignments that were just
removed by the
- // broker).
- if (state == MemberState.RECONCILING) {
+ // broker), or JOINING (member joining received empty assignment).
+ if (state == MemberState.RECONCILING || state ==
MemberState.JOINING) {
// This is the case where a member was RECONCILING an
unresolved
// assignment that was removed by the broker in a following
assignment.
Review Comment:
You're right, the comment is a dup of the one above and was not accurate
anymore, removed (agree with the suggestion of not overdoing the inline
comments, noted)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
