hachikuji commented on code in PR #15032: URL: https://github.com/apache/kafka/pull/15032#discussion_r1432175567
########## generator/src/main/java/org/apache/kafka/message/StructRegistry.java: ########## @@ -110,6 +110,7 @@ private void addStructSpecs(Versions parentVersions, List<FieldSpec> fields) { // Synthesize a StructSpec object out of the fields. StructSpec spec = new StructSpec(typeName, field.versions().toString(), + null, // version deprecations not supported at field level //FIXME Perhaps we should pass `Versions.NONE.toString` instead Review Comment: Do you intend to address the FIXME in this patch? ########## core/src/test/scala/unit/kafka/network/RequestConvertToJsonTest.scala: ########## @@ -118,6 +119,21 @@ class RequestConvertToJsonTest { assertEquals(expectedNode, actualNode) } + @Test + def testRequestHeaderNodeWithDeprecatedApiVersion(): Unit = { + val alterIsrRequest = FetchRequest.Builder.forConsumer(0, 0, 0, Collections.emptyMap()).build(0); Review Comment: nit: `fetchRequest`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org