showuon commented on code in PR #15026:
URL: https://github.com/apache/kafka/pull/15026#discussion_r1432205258
##########
core/src/test/scala/kafka/server/KafkaRequestHandlerTest.scala:
##########
@@ -321,4 +323,24 @@ class KafkaRequestHandlerTest {
assertEquals(0, brokerTopicMetrics.remoteCopyBytesLag)
}
+ @Test
+ def testRemoteLogMetadataCount(): Unit = {
+ val brokerTopicMetrics = setupBrokerTopicMetrics()
+
+ assertEquals(0, brokerTopicMetrics.remoteLogMetadataCount)
+ brokerTopicMetrics.recordRemoteLogMetadataCount(0, 1)
+ assertEquals(1, brokerTopicMetrics.remoteLogMetadataCount)
+
+ brokerTopicMetrics.recordRemoteLogMetadataCount(1, 2)
+ brokerTopicMetrics.recordRemoteLogMetadataCount(2, 3)
+ assertEquals(3, brokerTopicMetrics.remoteLogMetadataCount)
+
+
+ // verify there will be no minus value for a partition
Review Comment:
Oh, I forgot to remove it.
##########
core/src/test/scala/kafka/server/KafkaRequestHandlerTest.scala:
##########
@@ -321,4 +323,24 @@ class KafkaRequestHandlerTest {
assertEquals(0, brokerTopicMetrics.remoteCopyBytesLag)
}
+ @Test
+ def testRemoteLogMetadataCount(): Unit = {
+ val brokerTopicMetrics = setupBrokerTopicMetrics()
+
+ assertEquals(0, brokerTopicMetrics.remoteLogMetadataCount)
+ brokerTopicMetrics.recordRemoteLogMetadataCount(0, 1)
+ assertEquals(1, brokerTopicMetrics.remoteLogMetadataCount)
+
+ brokerTopicMetrics.recordRemoteLogMetadataCount(1, 2)
+ brokerTopicMetrics.recordRemoteLogMetadataCount(2, 3)
+ assertEquals(3, brokerTopicMetrics.remoteLogMetadataCount)
Review Comment:
Oops!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
