jolshan commented on code in PR #15023:
URL: https://github.com/apache/kafka/pull/15023#discussion_r1432819447
##########
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##########
@@ -1185,9 +1263,14 @@ else if (partition.equals(internalPart))
/**
* For testUpdatePartially, validates that updatedMetadata is matching
expected part1Metadata, part2Metadata, interalPartMetadata, nodes & more.
*/
- void validateForUpdatePartitionLeadership(Metadata updatedMetadata,
PartitionMetadata part1Metadata, PartitionMetadata part2Metadata,
PartitionMetadata internalPartMetadata,
- List<Node> expectedNodes, String expectedClusterId, Set<String>
expectedUnauthorisedTopics, Set<String> expectedInvalidTopics, Set<String>
expectedInternalTopics,
- Node expectedController, Map<String, Uuid> expectedTopicIds) {
+ void validateForUpdatePartitionLeadership(Metadata updatedMetadata,
+ PartitionMetadata part1Metadata,
PartitionMetadata part2Metadata, PartitionMetadata part12Metadata,
Review Comment:
nit: (for refactor) -- if we decided to put all the arguments on new lines,
let's do it for the all the arguments. The ones with three are a bit harder to
read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
