cadonna commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432897655
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -525,16 +526,37 @@ public void testHeartbeatState() {
@Test
public void testPollTimerExpiration() {
- heartbeatRequestManager = createHeartbeatRequestManager();
+ coordinatorRequestManager = mock(CoordinatorRequestManager.class);
+ membershipManager = mock(MembershipManager.class);
+ heartbeatState = mock(HeartbeatRequestManager.HeartbeatState.class);
+ heartbeatRequestState = spy(new
HeartbeatRequestManager.HeartbeatRequestState(
Review Comment:
Why is there still this spy?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -673,6 +673,9 @@ public void onHeartbeatRequestSent() {
MemberState state = state();
if (isStaled()) {
log.debug("Member {} is staled and is therefore leaving the group.
It will rejoin upon the next poll.", memberEpoch);
+ // TODO: Integrate partition revocation/loss callback
+ // Clear the current assignment and subscribed partitions because
the member has left the group
+ updateSubscription(new TreeSet<>(TOPIC_ID_PARTITION_COMPARATOR),
true);
Review Comment:
Is it correct that we have this call now in two places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
