[ 
https://issues.apache.org/jira/browse/KAFKA-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526451#comment-16526451
 ] 

John Roesler commented on KAFKA-7106:
-------------------------------------

Just preserving a comment from Guozhang:
{quote}This is a meta comment: currently we are leaking some segmented bytes 
store specific information into the general interface, such as 
{{segmentInterval}}, {{retainDuplicates}}. Suppose a user customized window 
bytes store, it does not necessarily need to be segmented at all. In addition, 
the {{windowSize}} and {{retentionPeriod}} are used today only because 
library's specific caching / logging layer relies on it, which is not generally 
applicable.

Ideally all of these parameters should not need to be instantiated by users, we 
could consider refactoring them a bit for better custom store support.
{quote}
 

This was on https://github.com/apache/kafka/pull/5257

> Remove segment/segmentInterval from Window definition
> -----------------------------------------------------
>
>                 Key: KAFKA-7106
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7106
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: John Roesler
>            Priority: Minor
>              Labels: needs-kip
>
> Currently, Window configures segment and segmentInterval properties, but 
> these aren't truly properties of a window in general.
> Rather, they are properties of the particular implementation that we 
> currently have: a segmented store. Therefore, these properties should be 
> moved to configure only that implementation.
>  
> This may be related to KAFKA-4730, since an in-memory window store wouldn't 
> necessarily need to be segmented.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to