atu-sharm commented on code in PR #14893:
URL: https://github.com/apache/kafka/pull/14893#discussion_r1433864949


##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##########
@@ -770,6 +771,9 @@ public void testSyncTopicConfigs() throws 
InterruptedException {
         Map<ConfigResource, Collection<AlterConfigOp>> configOps = 
Collections.singletonMap(configResource, ops);
         // alter configs on target cluster
         backup.kafka().incrementalAlterConfigs(configOps);
+        // wait until the configs are changed
+        waitForConfigValueChange(backup, backupTopic, "delete.retention.ms", 
"2000");
+        waitForConfigValueChange(backup, backupTopic, "retention.bytes", 
"2000");

Review Comment:
   As of now, i have added a lock for running the testcases which involves 
altering of same topic configs, your thoughts @C0urante @ashwinpankaj @mimaison 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to