philipnee commented on code in PR #15059:
URL: https://github.com/apache/kafka/pull/15059#discussion_r1434559814
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java:
##########
@@ -96,13 +96,13 @@
import static org.apache.kafka.common.utils.Utils.swallow;
/**
- * A client that consumes records from a Kafka cluster using the {@link
GroupProtocol#GENERIC generic group protocol}.
+ * A client that consumes records from a Kafka cluster using the {@link
GroupProtocol#CLASSIC classic group protocol}.
* In this implementation, all network I/O happens in the thread of the
application making the call.
*
* <p/>
*
* <em>Note:</em> per its name, this implementation is left for backward
compatibility purposes. The updated consumer
- * group protocol (from KIP-848) introduces allows users continue using the
legacy "generic" group protocol.
+ * group protocol (from KIP-848) introduces allows users continue using the
legacy "classic" group protocol.
Review Comment:
there's a bit of grammatical confusion here, perhaps: `group protocol ...
allows user continue...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
