divijvaidya commented on code in PR #14992:
URL: https://github.com/apache/kafka/pull/14992#discussion_r1434876077
##########
connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java:
##########
@@ -235,18 +235,31 @@ public Object toConnect(final Schema schema, final
JsonNode value) {
private final JsonDeserializer deserializer;
public JsonConverter() {
+ this(true);
+ }
+
+ /**
+ * Creates a JsonConvert initializing serializer and deserializer.
+ *
+ * @param enableModules permits to enable/disable the registration of
additional Jackson modules.
+ * <p>
+ * NOTE: This is visible only for testing
+ */
+ public JsonConverter(boolean enableModules) {
serializer = new JsonSerializer(
mkSet(),
- JSON_NODE_FACTORY
+ JSON_NODE_FACTORY,
+ enableModules
);
deserializer = new JsonDeserializer(
mkSet(
- // this ensures that the JsonDeserializer maintains full
precision on
- // floating point numbers that cannot fit into float64
- DeserializationFeature.USE_BIG_DECIMAL_FOR_FLOATS
+ // this ensures that the JsonDeserializer maintains full
precision on
Review Comment:
please follow original indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
