mjsax commented on code in PR #15061:
URL: https://github.com/apache/kafka/pull/15061#discussion_r1435548304
##########
streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java:
##########
@@ -44,15 +45,18 @@ public class DslWindowParams {
* caching and means that null values will be
ignored.
* @param emitStrategy defines how to emit results
* @param isSlidingWindow whether the requested store is a sliding window
+ * @param isTimestamped whether the requested store should be
timestamped (see {@link TimestampedWindowStore}
*/
public DslWindowParams(
final String name,
final Duration retentionPeriod,
final Duration windowSize,
final boolean retainDuplicates,
final EmitStrategy emitStrategy,
- final boolean isSlidingWindow
+ final boolean isSlidingWindow,
+ final boolean isTimestamped
Review Comment:
Looks like a public API change -- did we update the KIP accordingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
