Joker-5 commented on PR #14963: URL: https://github.com/apache/kafka/pull/14963#issuecomment-1868454660
> Hey @Joker-5, I took the ticket since your original PR seemed to only change the legacy consumer, so I thought it was just linked to the wrong ticket. > > I think there are some things missing here > > * enable unit / integration tests > * the way you implemented it, I think the interceptors will run as part of the background thread, but I think they should not interfere with the background thread and run as part of the application thread instead. > > How about we merge my PR which has the two changes and I add you in a `Co-authored-by` tag? Sorry again for the confusion. I understand, this is the second PR which i committed to Kafka. And I had learned a lot from your PR, so just do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
