divijvaidya commented on code in PR #15077:
URL: https://github.com/apache/kafka/pull/15077#discussion_r1436885274
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -2693,6 +2693,9 @@ class ReplicaManagerTest {
} else {
assertTrue(stray0.isInstanceOf[HostedPartition.Online])
}
+
+ replicaManager.shutdown()
+ logManager.shutdown()
Review Comment:
we should probably do it in "finally" otherwise we we may not close them if
assertion fails or an exception is thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
