[ 
https://issues.apache.org/jira/browse/KAFKA-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527729#comment-16527729
 ] 

ASF GitHub Bot commented on KAFKA-7111:
---------------------------------------

rajinisivaram closed pull request #5312: KAFKA-7111: Log error connecting to 
node at a higher log level
URL: https://github.com/apache/kafka/pull/5312
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java 
b/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
index ea16ac9587f..720a7814752 100644
--- a/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
+++ b/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
@@ -869,7 +869,7 @@ private void initiateConnect(Node node, long now) {
             connectionStates.disconnected(nodeConnectionId, now);
             /* maybe the problem is our metadata, update it */
             metadataUpdater.requestUpdate();
-            log.debug("Error connecting to node {}", node, e);
+            log.warn("Error connecting to node {}", node, e);
         }
     }
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Review the NetworkClient log level used
> ---------------------------------------
>
>                 Key: KAFKA-7111
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7111
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>            Reporter: Luan Cestari
>            Assignee: Stanislav Kozlovski
>            Priority: Trivial
>
> Hi,
>  
> I was using Kafka on some projects and unfortunately I had to use Debug (and 
> some times even Trace) log level to see some issues. One of the most recently 
> cases was: 
> [https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java#L872]
>  
> If I got the name of the broker and it is unreachable, the errors should be 
> more severe than "DEBUG" level IMHO. I would at least put a INFO level for 
> this case or ERROR level (which seems to fit better but I don't know the 
> practices used in the project).
>  
> Thank you in advance
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to