clolov commented on code in PR #15106:
URL: https://github.com/apache/kafka/pull/15106#discussion_r1439447074


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java:
##########
@@ -642,11 +645,12 @@ public void 
shouldRestoreFromBeginningAndCheckCompletion() {
 
     @Test
     public void shouldCheckCompletionIfPositionLargerThanEndOffset() {
+        setupActiveStateManager();

Review Comment:
   Yeah, the reason for not doing it in @before is that since not all tests 
exercise the methods in the stubbing Mockito complains that there are unused 
stubs. This way we only stub in the tests where the code is exercised!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to