ijuma commented on code in PR #15118:
URL: https://github.com/apache/kafka/pull/15118#discussion_r1440881725
##########
core/src/main/java/kafka/server/builders/LogManagerBuilder.java:
##########
@@ -48,7 +48,7 @@ public class LogManagerBuilder {
private int maxTransactionTimeoutMs = 15 * 60 * 1000;
private ProducerStateManagerConfig producerStateManagerConfig = new
ProducerStateManagerConfig(60000, false);
private int producerIdExpirationCheckIntervalMs = 600000;
- private MetadataVersion interBrokerProtocolVersion =
MetadataVersion.latest();
+ private MetadataVersion interBrokerProtocolVersion =
MetadataVersion.latest(true);
Review Comment:
An enum instead of boolean would make this a lot more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
