cadonna commented on code in PR #15117:
URL: https://github.com/apache/kafka/pull/15117#discussion_r1441848969
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -1164,9 +1243,12 @@ public void
shouldHandleMultipleRemovedTasksFromStateUpdater() {
final StreamTask taskToUpdateInputPartitions = statefulTask(taskId03,
taskId03ChangelogPartitions)
.inState(State.RESTORING)
.withInputPartitions(taskId03Partitions).build();
+ final StreamTask taskToCloseReviveAndUpdateInputPartitions =
statefulTask(taskId04, taskId04ChangelogPartitions)
+ .inState(State.RESTORING)
+ .withInputPartitions(taskId04Partitions).build();
Review Comment:
I think there was a similar indentation issue on line 1713 that you fixed. I
also saw one on line 1652.
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -1164,9 +1243,12 @@ public void
shouldHandleMultipleRemovedTasksFromStateUpdater() {
final StreamTask taskToUpdateInputPartitions = statefulTask(taskId03,
taskId03ChangelogPartitions)
.inState(State.RESTORING)
.withInputPartitions(taskId03Partitions).build();
+ final StreamTask taskToCloseReviveAndUpdateInputPartitions =
statefulTask(taskId04, taskId04ChangelogPartitions)
+ .inState(State.RESTORING)
+ .withInputPartitions(taskId04Partitions).build();
Review Comment:
This does not seem done. But nevermind, if it is just this I will of course
not block the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
