philipnee commented on PR #15000: URL: https://github.com/apache/kafka/pull/15000#issuecomment-1877478293
hi @lucasbru - thanks. i personally prefer to make consumer interceptor thread safe because firstly, (i think) it simplifies the code quite a bit and secondly, it is possible to miss the interceptor invocation if user fail to poll/close after a commit is sent. latter is a bigger problem i think. do you have an idea of how to fix this? `When would we not trigger the interceptor in this case?` i think we always want to trigger onCommit interceptor if provided. so I think after sending the last commit sync on close, we just need to clear the queue, close the network thread, and invoke the callbacks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
