divijvaidya commented on code in PR #15128:
URL: https://github.com/apache/kafka/pull/15128#discussion_r1442237669
##########
connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java:
##########
@@ -119,16 +117,16 @@ private boolean isInternalRequest(ContainerRequestContext
requestContext) {
public static class BasicAuthCallBackHandler implements CallbackHandler {
- private String username;
- private String password;
+ private final String username;
Review Comment:
I have fixed all such "field not being final warnings" in
https://github.com/apache/kafka/pull/15072
Please check when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
