showuon commented on code in PR #15133: URL: https://github.com/apache/kafka/pull/15133#discussion_r1442611638
########## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ########## @@ -529,18 +534,28 @@ class BrokerTopicMetrics(name: Option[String], configOpt: java.util.Optional[Kaf } } -class BrokerTopicAggregatedMetric() { +class BrokerTopicAggregatedMetric(allTopics: Boolean = false) { private val partitionMetricValues = new ConcurrentHashMap[Int, Long]() + private val topicMetricValues = new ConcurrentHashMap[String, Long]() Review Comment: add a `topicMetricValues` for allTopics case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org