C0urante commented on code in PR #15110:
URL: https://github.com/apache/kafka/pull/15110#discussion_r1444091488


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##########
@@ -170,6 +170,7 @@ private <T> HttpResponse<T> httpRequest(HttpClient client, 
String url, String me
             }
         } catch (IOException | InterruptedException | TimeoutException | 
ExecutionException e) {
             log.error("IO error forwarding REST request: ", e);
+            Thread.currentThread().interrupt();

Review Comment:
   Shouldn't we only do this if we've caught an `InterruptedException`? There 
are other potential exception types that could cause us to enter this code 
block right now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to