mimaison commented on code in PR #14668:
URL: https://github.com/apache/kafka/pull/14668#discussion_r1444787636
##########
core/src/test/scala/unit/kafka/admin/DescribeConsumerGroupTest.scala:
##########
@@ -351,7 +367,9 @@ class DescribeConsumerGroupTest extends
ConsumerGroupCommandTest {
val (result, succeeded) =
TestUtils.computeUntilTrue(service.collectGroupOffsets(group)) {
case (state, assignments) =>
val testGroupAssignments = assignments.toSeq.flatMap(_.filter(_.group
== group))
+
Review Comment:
Let's try to not undo unnecessary changes like these
##########
core/src/test/scala/unit/kafka/admin/DescribeConsumerGroupTest.scala:
##########
@@ -35,9 +35,11 @@ class DescribeConsumerGroupTest extends
ConsumerGroupCommandTest {
private val describeTypeState = Array(Array("--state"))
private val describeTypes = describeTypeOffsets ++ describeTypeMembers ++
describeTypeState
- @Test
- def testDescribeNonExistingGroup(): Unit = {
- TestUtils.createOffsetsTopic(zkClient, servers)
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testDescribeNonExistingGroup(quorum: String): Unit = {
+ createOffsetsTopic();
Review Comment:
Nit: Can we remove the unneeded semicolon?
Same below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
