nizhikov commented on PR #14871:
URL: https://github.com/apache/kafka/pull/14871#issuecomment-1881277689

   @ijuma We can use direct calls like 
`QuotaConfigs.userAndClientQuotaConfigs().names()`, 
`QuotaConfigs.scramMechanismsPlusUserAndClientQuotaConfigs().names()` to obtain 
config names for help message in `ConfigCommand`.
   
   But I can't see how `DynamicConfig.Broker.names` can be created without 
accessing to `KafkaConfig.configKeys`
   
   ```
   object DynamicConfig {
   
     object Broker {
   ...
       DynamicBrokerConfig.addDynamicConfigs(brokerConfigDef)
     }
   }
   
   object DynamicBrokerConfig {
     private[server] def addDynamicConfigs(configDef: ConfigDef): Unit = {
       KafkaConfig.configKeys.forKeyValue { (configName, config) =>
         if (AllDynamicConfigs.contains(configName)) {
           configDef.define(config.name, config.`type`, config.defaultValue, 
config.validator,
             config.importance, config.documentation, config.group, 
config.orderInGroup, config.width,
             config.displayName, config.dependents, config.recommender)
         }
       }
     }
   }
   ``


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to