[
https://issues.apache.org/jira/browse/KAFKA-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804348#comment-17804348
]
Phuc Hong Tran edited comment on KAFKA-15558 at 1/8/24 3:45 PM:
----------------------------------------------------------------
[~schofielaj], can you elaborate a bit more about the improment we need? What I
get from the original commenter is that we should also use timer to control the
runtime of operation like validating fetch positions and reseting fetch
positions, which I already saw you implemented.
was (Author: JIRAUSER301295):
[~schofielaj], can you elaborate a bit more about it? What I get from the
original commenter is that we should also use timer to control the runtime of
operation like validating fetch positions and reseting fetch positions, which I
already saw you implemented.
> Determine if Timer should be used elsewhere in
> PrototypeAsyncConsumer.updateFetchPositions()
> --------------------------------------------------------------------------------------------
>
> Key: KAFKA-15558
> URL: https://issues.apache.org/jira/browse/KAFKA-15558
> Project: Kafka
> Issue Type: Task
> Components: clients, consumer
> Reporter: Kirk True
> Assignee: Phuc Hong Tran
> Priority: Major
> Labels: consumer-threading-refactor, kip-848-preview
> Fix For: 3.8.0
>
>
> This is a followup ticket based on a question from [~junrao] when reviewing
> the [fetch request manager pull
> request|https://github.com/apache/kafka/pull/14406]:
> {quote}It still seems weird that we only use the timer for
> {{{}refreshCommittedOffsetsIfNeeded{}}}, but not for other cases where we
> don't have valid fetch positions. For example, if all partitions are in
> {{AWAIT_VALIDATION}} state, it seems that {{PrototypeAsyncConsumer.poll()}}
> will just go in a busy loop, which is not efficient.
> {quote}
> The goal here is to determine if we should also be propagating the Timer to
> the validate positions and reset positions operations.
> Note: we should also investigate if the existing {{KafkaConsumer}}
> implementation should be fixed, too.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
