DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1446824176
##########
core/src/main/scala/kafka/server/ControllerConfigurationValidator.scala:
##########
@@ -113,6 +121,22 @@ class ControllerConfigurationValidator(kafkaConfig:
KafkaConfig) extends Configu
val properties = new Properties()
config.entrySet().forEach(e => properties.setProperty(e.getKey,
e.getValue))
ClientMetricsConfigs.validate(resource.name(), properties)
+ case GROUP =>
+ validateGroupName(resource.name())
+ val properties = new Properties()
+ val nullConsumerGroupConfigs = new mutable.ArrayBuffer[String]()
+ config.entrySet().forEach(e => {
+ if (e.getValue == null) {
+ nullConsumerGroupConfigs += e.getKey
+ } else {
+ properties.setProperty(e.getKey, e.getValue)
+ }
+ })
+ if (nullConsumerGroupConfigs.nonEmpty) {
+ throw new InvalidConfigurationException("Null value not supported
for consumer group configs: " +
Review Comment:
Done
##########
core/src/main/scala/kafka/server/metadata/DynamicConfigPublisher.scala:
##########
@@ -114,6 +114,18 @@ class DynamicConfigPublisher(
s"${resource.name()} with new configuration:
${toLoggableProps(resource, props).mkString(",")} " +
s"in $deltaName", t)
})
+ case GROUP =>
+ // Apply changes to a group's dynamic configuration.
+
dynamicConfigHandlers.get(ConfigType.GROUP).foreach(consumerGroupConfigHandler
=>
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
