philipnee commented on PR #14531:
URL: https://github.com/apache/kafka/pull/14531#issuecomment-1884215706
@jimbogithub - thanks for the PR, i've got a few questions to clarify:
- `KafkaProducer.partition(...) not throw IllegalArgumentException if the
Partitioner returns RecordMetadata.UNKNOWN_PARTITION `: I'm not sure if any
partitioner actually return this UNKNOWN_PARTITION. it should be returned by
the producer.partition no?
- to the question above, I think different partitions has different
implementations of handling missing topics. but since they all return some
partition, are the default behaviors insufficient? bottom line is I'm not 100%
convincing that the fallback to default is actually needed.
- there's no test for the change you made. i think it would be good to add
some to demonstrate some of the use cases.
- I would also update the PR description. you can just use whatever
described in the PR.
@jolshan - if you get time maybe you can review this? it seems like you
implemented a few partitioner so you are probably the better person to speak
about this... thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
