gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450907710
########## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrantRecordSinkConnector.java: ########## @@ -54,7 +65,16 @@ public void put(Collection<SinkRecord> records) { .computeIfAbsent(rec.topic(), v -> new HashMap<>()) .computeIfAbsent(rec.kafkaPartition(), v -> new TopicPartition(rec.topic(), rec.kafkaPartition())); committedOffsets.put(tp, committedOffsets.getOrDefault(tp, 0) + 1); - reporter.report(rec, new Throwable()); + Throwable error = new Throwable(); + // Test synchronous and asynchronous reporting, allowing for re-ordering the errant reports Review Comment: What verification are you thinking about? Currently we're asserting that at least N errors are reported in total after delivering N records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org