mjsax commented on code in PR #13909:
URL: https://github.com/apache/kafka/pull/13909#discussion_r1381140128
##########
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##########
@@ -155,6 +155,29 @@ public ConfigDef define(String name, Type type, Object
defaultValue, Validator v
return define(new ConfigKey(name, type, defaultValue, validator,
importance, documentation, group, orderInGroup, width, displayName, dependents,
recommender, false));
}
+ /**
+ * Define a new configuration
+ * @param name the name of the config parameter
+ * @param type the type of the config
+ * @param defaultValue the default value to use if this config isn't
present
+ * @param validator the validator to use in checking the
correctness of the config
+ * @param importance the importance of this config
+ * @param documentation the documentation string for the config
+ * @param group the group this config belongs to
+ * @param orderInGroup the order of this config in the group
+ * @param width the width of the config
+ * @param displayName the name suitable for display
+ * @param dependents the configurations that are dependents of this
configuration
+ * @param recommender the recommender provides valid values given
the parent configuration values
+ * @param overwrittenValue the overwritten value of this configuration
Review Comment:
> the overwritten value
Not very descriptive IMHO. Can we explain it better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
