OmniaGM commented on code in PR #15159: URL: https://github.com/apache/kafka/pull/15159#discussion_r1453859778
########## server/src/main/java/org/apache/kafka/server/config/ClientQuotaManagerConfig.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.config; + +public class ClientQuotaManagerConfig { + // Always have 10 whole windows + 1 current window + public static final int DEFAULT_NUM_QUOTA_SAMPLES = 11; + public static final int DEFAULT_QUOTA_WINDOW_SIZE_SECONDS = 1; + + public final int numQuotaSamples; + public final int quotaWindowSizeSeconds; + + /** + * Configuration settings for quota management + * + * @param numQuotaSamples The number of samples to retain in memory + * @param quotaWindowSizeSeconds The time span of each sample + */ + public ClientQuotaManagerConfig(int numQuotaSamples, int quotaWindowSizeSeconds) { + this.numQuotaSamples = numQuotaSamples; + this.quotaWindowSizeSeconds = quotaWindowSizeSeconds; + } + + public ClientQuotaManagerConfig() { + this(DEFAULT_NUM_QUOTA_SAMPLES, DEFAULT_QUOTA_WINDOW_SIZE_SECONDS); + } + + public ClientQuotaManagerConfig(int numQuotaSamples) { + this(numQuotaSamples, DEFAULT_QUOTA_WINDOW_SIZE_SECONDS); + } +} Review Comment: Added a line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
