philipnee commented on code in PR #15000:
URL: https://github.com/apache/kafka/pull/15000#discussion_r1453868310
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -93,9 +94,11 @@ public CommitRequestManager(
final SubscriptionState subscriptions,
final ConsumerConfig config,
final CoordinatorRequestManager coordinatorRequestManager,
+ final OffsetCommitCallbackInvoker offsetCommitCallbackInvoker,
Review Comment:
looking back at the implementation - now i think it is rather unnecessary to
have these finals in the parameters. I wonder if you think we should clean
them up in the future...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
