lianetm commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1453945617
##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -753,6 +753,10 @@ public void subscribe(Pattern pattern,
ConsumerRebalanceListener listener) {
public void subscribe(Pattern pattern) {
delegate.subscribe(pattern);
}
+ @Override
+ public void subscribe(SubscriptionPattern pattern,
ConsumerRebalanceListener callback) {}
Review Comment:
I expect we should be calling the delegate.subscribe(SubscriptionPattern..)
here, otherwise the actual implementation in the AsyncKafkaConsumer won't be
called. Similar to the subscribe(Pattern..)
(This KafkaConsumer is the user-facing api, that ends up calling the Legacy
or Async consumer via the delegate)
##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -753,6 +753,10 @@ public void subscribe(Pattern pattern,
ConsumerRebalanceListener listener) {
public void subscribe(Pattern pattern) {
delegate.subscribe(pattern);
}
+ @Override
+ public void subscribe(SubscriptionPattern pattern,
ConsumerRebalanceListener callback) {}
+ @Override
+ public void subscribe(SubscriptionPattern pattern) {}
Review Comment:
Same as above comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
