nizhikov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1456546534


##########
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##########
@@ -0,0 +1,263 @@
+/*

Review Comment:
   > I think when we have had two word folders we usually put a dash between 
them (ie consumer-group)
   
   Dash can't be used in java package name.
   
   > They follow a pattern of coordinator/group
   
   We can move classes to `org.apache.kafka.tools.consumer.group` package.
   What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to