rreddy-22 commented on code in PR #15211:
URL: https://github.com/apache/kafka/pull/15211#discussion_r1459497325
##########
clients/src/main/java/org/apache/kafka/common/ConsumerGroupState.java:
##########
@@ -31,7 +31,15 @@ public enum ConsumerGroupState {
COMPLETING_REBALANCE("CompletingRebalance"),
STABLE("Stable"),
DEAD("Dead"),
- EMPTY("Empty");
+ EMPTY("Empty"),
+
+ // New consumer group states are temporary here. It will be removed when
+ // the KIP-848 is completed.
+ NEW_CONSUMER_GROUP_EMPTY("empty"),
Review Comment:
So it was decided that we would make the state filters case insensitive,
which means that for states that are common in both the old protocol and the
new protocol, we return all groups in that state. Ex: "Stable" returns are
groups that are stable. The enum will therefore contain:
`public enum ConsumerGroupState {
UNKNOWN("Unknown"),
PREPARING_REBALANCE("PreparingRebalance"),
COMPLETING_REBALANCE("CompletingRebalance"),
STABLE("Stable"),
DEAD("Dead"),
EMPTY("Empty"),
ASSIGNING("Assigning"),
RECONCILING("Reconciling");
}`
##########
clients/src/main/java/org/apache/kafka/common/ConsumerGroupState.java:
##########
@@ -31,7 +31,15 @@ public enum ConsumerGroupState {
COMPLETING_REBALANCE("CompletingRebalance"),
STABLE("Stable"),
DEAD("Dead"),
- EMPTY("Empty");
+ EMPTY("Empty"),
+
+ // New consumer group states are temporary here. It will be removed when
+ // the KIP-848 is completed.
+ NEW_CONSUMER_GROUP_EMPTY("empty"),
Review Comment:
So it was decided that we would make the state filters case insensitive,
which means that for states that are common in both the old protocol and the
new protocol, we return all groups in that state. Ex: "Stable" returns are
groups that are stable. The enum will therefore contain:
public enum ConsumerGroupState {
UNKNOWN("Unknown"),
PREPARING_REBALANCE("PreparingRebalance"),
COMPLETING_REBALANCE("CompletingRebalance"),
STABLE("Stable"),
DEAD("Dead"),
EMPTY("Empty"),
ASSIGNING("Assigning"),
RECONCILING("Reconciling");
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
