C0urante commented on code in PR #15233:
URL: https://github.com/apache/kafka/pull/15233#discussion_r1459683206
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java:
##########
@@ -132,7 +127,6 @@ public void stop() {
*/
public void cancel() {
cancelled = true;
- retryWithToleranceOperator.triggerStop();
Review Comment:
I know it's a little strange for this class to hold onto the
`RetryWithToleranceOperator` when its only interaction is to stop it, but this
seemed reasonable in https://github.com/apache/kafka/pull/12478 because it
saved us the potential headache of adding another subclass to `WorkerTask` that
might forget to invoke `RetryWithToleranceOperator::triggerStop`.
I'm not hugely opposed to changing this part and it's not a blocker, but
FWIW I think this change is unnecessary.
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/DeadLetterQueueReporter.java:
##########
@@ -124,19 +124,17 @@ public static DeadLetterQueueReporter
createAndSetup(Map<String, Object> adminPr
* @param context processing context containing the raw record at {@link
ProcessingContext#original()}.
* @return the future associated with the writing of this record; never
null
*/
- @SuppressWarnings("unchecked")
Review Comment:
🙌
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/TransformationChain.java:
##########
@@ -32,18 +32,18 @@
* Represents a chain of {@link Transformation}s to be applied to a {@link
ConnectRecord} serially.
* @param <R> The type of record (must be an implementation of {@link
ConnectRecord})
*/
-public class TransformationChain<R extends ConnectRecord<R>> implements
AutoCloseable {
+public class TransformationChain<T, R extends ConnectRecord<R>> implements
AutoCloseable {
Review Comment:
Can we update the Javadocs right above with a description of the new type
parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
