nicktelford commented on PR #15137: URL: https://github.com/apache/kafka/pull/15137#issuecomment-1909852487
> Hey @nicktelford , I'll try to take a look at this here and there and I can't speak for the Confluent folks, but I have to say it's pretty intimidating to see a PR with 3000 LOC and over 100 files changed...especially one that touches on some complicated stuff that's fundamental to Kafka Streams. > > I know you've already tried to break this work up into multiple PRs but for your own sake as much as ours, can you take another look at whether you can peel off any more into separate PRs? I'm just worried that it's going to be really hard for this to make progress as such a large PR, and the longer it's stalled the harder it'll be to keep it updated. Hi @ableegoldman, I totally understand, which is why I already peeled some out. My general policy with PRs is that they must be committable independently, without breaking the build or cause performance regressions. I'll do another pass over this to see if I can break a bit more out, but I can't imagine it'll be more than a few LoC here and there. If you would accept PRs that cannot be merged independently without breaking the build, or perhaps use a staging branch to integrate the changes piece-by-piece, then I can definitely break it up some more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
