rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1467026136
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -452,21 +453,38 @@ public Group group(String groupId, long committedOffset)
throws GroupIdNotFoundE
/**
* Get the Group List.
*
- * @param statesFilter The states of the groups we want to list.
- * If empty all groups are returned with their state.
- * @param committedOffset A specified committed offset corresponding to
this shard
+ * @param statesFilter The states of the groups we want to list.
+ * If empty, all groups are returned with their
state.
+ * @param typesFilter The types of the groups we want to list.
+ * If empty, all groups are returned with their
type.
+ * @param committedOffset A specified committed offset corresponding to
this shard.
*
* @return A list containing the ListGroupsResponseData.ListedGroup
*/
+ public List<ListGroupsResponseData.ListedGroup> listGroups(
+ Set<String> statesFilter,
+ Set<String> typesFilter,
+ long committedOffset
+ ) {
+ // Converts each string to a value in the GroupType enum while being
case-insensitive.
+ Set<Group.GroupType> enumTypesFilter = typesFilter.stream()
+ .map(Group.GroupType::parse)
+ .collect(Collectors.toSet());
Review Comment:
We were able to ignore the unknown states easily because we didn't have to
parse them and assign an enum type right? It would just check if the state
exists in the filter set, but here since we're tryna parse and assign ig it
needs to be handled differently? Lmk if my understanding is off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
